Jonathan Hedley comments

Results 188 comments of


                                            Jonathan Hedley

Problems with Elements class array methods updating the DOM

@821938089 when I have an update I will definitely post it here. Currently I am leaning towards a method like `deselect()` which will remove the Element from the Elements array,...

Problems with Elements class array methods updating the DOM

OK done -- I added `elements.deselect(object)`, `elements.deselect(index)`, and `elements.asList()`.

Problems with Elements class array methods updating the DOM

OK, added `elements.deselectAll()`

Use TreeMap to store headers

Hmm - this looks neater, but it changes the semantics. The LinkedHashMap implementation keeps the headers in the order they are added. But the TreeMap will sort them alphabetically. The...

Use TreeMap to store headers

@Isira-Seneviratne I think we need to close this one, as mentioned, using a TreeMap will lose the insert order of the headers. I want to keep the insertion order so...

Bump minimum Android API level to 21

Is there anything other that might be useful other than StandardCharsets? That doesn't really make any difference from my POV, being that we statically initialize UTF-8 anyway at startup. I...

Bump minimum Android API level to 21

OK, try-with-resources will be good to have. I have marked this for the 1.19.1 milestone (vs 1.18.2), as I feel that the change warrants being in a major bump.

Bump minimum Android API level to 21

Thanks, merged!

Bump com.github.siom79.japicmp:japicmp-maven-plugin from 0.24.2 to 0.25.0

Looks like it requires a newer Maven version than what's in the fuzzer's container; will need to upgrade that first and get a PR merged.

Bump com.github.siom79.japicmp:japicmp-maven-plugin from 0.24.2 to 0.25.0

OK I have raised https://github.com/google/oss-fuzz/pull/14489 for the upgrade