Jonathan Hedley comments

Results 188 comments of


                                            Jonathan Hedley

Closed parser/tree builder API

There's no strong reason, other than the I don't think that the API is very good or one that should be contractual yet. Happy to take suggestions on cleaning it...

nth:child not limiting to range correctly in `p:nth-child(n+2):nth-child(-n+2)`

Please provide a fragment and the selector so anyone can replicate this. Best to use try.jsoup as mentioned.

Self closing field should be ignored for tags that aren't self closing per spec

Actually I looked at this the other day but forgot to add my notes. The spec and Chrome will ignore the self-closing flag. (So it would parse as `content`.) It...

Element factory method

Hi -- this makes sense and I think is a good idea. One issue with them being static methods (Element.of or Jsoup.parseElement) is that HTML parse settings cannot be applied...

Element factory method

@xiaoxianma thanks - please see my comments on #1521. Similar thoughts on this.

Implemented redirect via HTML meta refresh tag support

Hi, thanks for this. Can you add some integration tests, and unit tests for the meta tag -> url parser? I think this only works if the content value is...

Implement buffer recycling for CharacterReader

Good stuff, thanks! I may move some things around (not sure if the recycler should be a public contract API, etc). Enjoy your vacation :)

Add Node#noteType() and constants?

We could potentially add it. There is `nodeName` which returns a unique string. Generally I've just used the class instanceOf. https://jsoup.org/apidocs/org/jsoup/nodes/Node.html#nodeName()

Document::location does not contain fragment identifier

I guess we could update Connection to remember the fragment. It's a client-side only thing and doesn't get sent to the server during the connection, hence why it's not in...

Document::location does not contain fragment identifier

Sure, why not? Happy to review a PR if you want to get in there yourself.