Jonathan Hedley comments

Results 188 comments of


                                            Jonathan Hedley

Minor performance optimizations

Cool, can you provide a PR and a benchmark?

Minor performance optimizations

Thanks merged, as noted.

Some html tags didn't support by Jsoup?

Closing - incomplete report.

text() is missing a separator space between <button> text nodes

Thanks, have implemented this. Per the spec it's an inline tag which doesn't really require spaces to be added, but given how browsers render it, I think it makes sense.

Incorrect header encoding conversion

Can you give me the code for this vs screenshots so that I can review?

Incorrect header encoding conversion

OK, I've moved the re-encoding fix-up to only response headers. That's in place to fix #706 where the header was encoded as 8559 but held UTF bytes instead. Browsers seem...

Incorrect header encoding conversion

Can you give me a sample URL or code so that I can actually review the server's response properly?

Incorrect header encoding conversion

I get caught in bot detections when I try this. Can you provide sample code so that I can try and repro? I won't add a configuration option unless I...

Incorrect header encoding conversion

Thanks, that's good sleuthing! Need to think of a good way to detect and handle this situation...

Fix NullPointerException in case a custom document is passed to W3CDom

Great, TY!