Joshua Humphries
Joshua Humphries
Just pushed a minor commit based on feedback from @pkwarren: a "dangling" space before a semicolon looks funny. So we won't try to preserve that whitespace.
I think this will help: https://github.com/bufbuild/protocompile/pull/46
Okay. I think I've finally wrestled this thing into shape. It's not pretty. I ended up making quite a lot of changes with the _hope_ of simplifying some of the...
@pkwarren, @bufdev, I think this is finally ready to go. Though I probably need to double-check the differences in golden outputs and amend/improve the change log wording before merging... PTAL.
This is a duplicate of #195. @asador, please see that other issue for a resolution. The problem is that the Windows command tool/shell does not support quoting/escaping in the way...
@murfel, it is not grpcurl picking a random port, it is the operating system. This is standard behavior for the client side of TCP connections: https://en.wikipedia.org/wiki/Ephemeral_port. While some TCP libraries...
ping @mcy, if you have a chance to make another pass over this
@mcy, I think I've addressed your latest comments. PTAL.
I wholeheartedly agree that a published official spec would be _hugely_ valuable to the community. A spec should be a lot more than just the grammar. The grammar defines the...
This appears to have been fixed. The grammars for both proto2 and proto3 both now have the following production, explicitly allowing a minus sign: ``` enumField = ident "=" [...