Joshua Humphries

Results 433 comments of Joshua Humphries

The first of those three examples does appear to be an issue. But the others do not. In the second example, it renders the duration as `5: ""` because it...

That's not what's going on though. A more accurate example would be `Bar` messages `{foo: {}}` vs. `{foo: {bar: 0}}` which are _not_ considered different. In the case you describe,...

> It appears to be a null message, not an empty message. Why do you say that? The raw output of interest: ``` // goprotoc 919191 { 21 { 5:...

FYI, of those three cases above -- where I said the first was a real issue but the others boiled down to the same symptom I had described earlier --...

@hitzhangjie, this is expected and is the same behavior you'll get with `protoc`, whose implementation is the defacto "spec" for the protocol buffers language.

@ericliu1990, does this file import itself (see line 6)? If this is the file you are trying to parse, the error message appears to suggest that the import at line...

@johanbrandhorst, neat! Do I need to do anything with repo config for this to work? Where would I see the checks? Should they show up above, like alongside the "Circle...

@richardartoul, thanks for opening this issue. I'm happy to discuss how to improve performance in this library. I'll address these in bullets, corresponding to each bullet you wrote: 1. Using...

Can you not use the exported `proto.Buffer` (in the "github.com/golang/protobuf/proto" package)? If not, I don't think a wrapper belongs in the `dynamic` package, since it is not really specific to...