Joshua Humphries
Joshua Humphries
FWIW, I ended up taking a completely different approach, to address a TODO in here and also to have more control over the line breaks and expansion of nested message...
@mcy, if you agree with the proposed "correct and consistent" source code info above, you can see a fix that implements this in #10470.
@mcy, @mkruskal-google, can this be reopened since the fix was reverted in #10658?
There is definitely code in the wild that expects qualified names (dot-separated sequence of identifiers, such as in type names, extension names in message literals and custom options) to _allow_...
FWIW, _most_ languages that use dots as a "selector" operator for building qualified names _do_ support whitespaces around the dots, even if most users don't ever write code that way....
@mkruskal-google, I guess you are referring to the red "Bazel" and various "Windows C++ ..." kokoro builds? How do I troubleshoot these? The links for the failed checks do not...
@mkruskal-google, I don't suppose you could provide any advice on how I'd run linux tests with `--config=asan`? Is that a command-line argument to `bazel`? Also, I don't suppose you can...
I am hoping the same issue tickling ASAN errors may also be causing the Windows issues. I really have no idea how a NUL character is sneaking into that string...
@mkruskal-google, looks like everything is green. 🎉 Anything else I can do to help this get merged safely?
> If we can wait a few weeks this would be much easier to port than it is today @mkruskal-google, in my ideal world, this would get into the next...