John Högberg

Results 123 comments of John Högberg

Segfault when using `setelement` and `erlang:system_time`

Thanks for your report, and sorry for taking so long to start working on it. I've fixed it in #8898 :-)

Can we get a warning on obviously non-boolean part of a guard?

Thanks for raising this issue! The warning for misuse of `or/2` is an "opportunistic" one in compiler pass, not `erl_lint`, and we're rather hesitant to add more of those. We'd...

Add a log message when the logger enters burst protection mode

Sorry for the late reply! Yes, we think this is a good idea. Feel free to make a PR :-)

Add is_external_fun/1 and is_local_fun/1 guards

I agree that this would be useful. I'd like to change the names however (and not just here, though the ship might have sailed already) as "local fun" and "external...

Add is_external_fun/1 and is_local_fun/1 guards

I don't think it's common here. A "local" fun is not tied to a particular instance of a node, and works just fine everywhere as long as the required code...

Add is_external_fun/1 and is_local_fun/1 guards

I like it, though I'm wary of how verbose it will seem a decade down the line when we're all familiar. `is_binary_data` would've made sense at the time binaries were...

Add is_external_fun/1 and is_local_fun/1 guards

You can also argue that F1 is a true closure because it closes the _specific module version_ it's in.

argparse says argument is optional when it's required

Thanks, we'll look into it when we find the time, though it may take a while with 27-rc1 and 26.3 coming up soon, so we'd welcome a PR if anyone's...

[erlc] internal error in pass beam_ssa_opt

Thanks for reporting! This appears related to https://github.com/erlang/otp/issues/6599, and we're still working on that.

Add option to pause proc timer to erlang:suspend_process/2

Thanks for the PR! Most of us are away on vacation so we have limited time to look at this. We'll get back to it once we're back from vacation....