John Hildenbiddle

Results 122 comments of John Hildenbiddle

I'd also like to see the ability to rename files added.

Thanks, @chenyulun. I will investigate.

The HTML `` element does not support the `disabled` attribute. IE supports it, but no other browser does. This is why the ponyfill ignores the `disabled` attribute on `` elements....

Hi @mengqiy. Happy to help. There are three important things to consider: 1. The HTML structure and class name assignments are handled by docsify, not docsify-themeable. Docsify-themeable does include a...

Hi @dlewand691, I'd love to add it. I considered it when developing the project, but Safari (and other WebKit-based browsers) didn't support any method of calculating new text sizes without...

@tapio, @johannespfeiffer -- Disappointing to see that PR has not been merged. The dependency on an outdated version of `chokidar` was breaking our tests on macOS (see https://github.com/microsoft/playwright/issues/3090 for details)....

The docs don't mention this. I found the solutions here: https://github.com/tapio/live-server/issues/169#issuecomment-270846429 ```js // Start liveServer.start({ /* Options */ }); // Stop liveServer.shutdown(); ```

@trusktr -- > Why do we check if it doesn't start with mailto:? Does that break mailto links? I don't know the history, but my guess is that the original...

I agree with @Koooooo-7. We can't default to settings `withCredentials` to `true`. My initial thought is that modifying the xhr object is best handled via a new hook instead of...

Based on the [comments](https://github.com/docsifyjs/docsify/pull/495#issuecomment-390524354) in #495, the decision back in 2018 was to implement this feature as a third-party plugin. I'm guessing that this never happened given that a "skip...