Javier Galan
Javier Galan
The `dataset.rml` is not present, to check that it is coherent with the code.
Inside `pipeline/datasets/` there should be the validation macro and the rml.
@lobis what is this?
What happens if we want some of the methods that have been implemented in `TRestAnalysisTree`?
Perhaps we could just implement a `TRestAnalysisTree::Export` method that creates a raw `TTree`, that can be further read using `uproot`. Anyhow I think the philosophy should be that we build...
> they could have been REST-agnostic: analyze REST data with plain ROOT macros, which would make sharing data easier. We could always share data by exporting a `TRestDataSet` but promoting...
> My point is that the files created by REST should be as compatible as possible, without limiting ourselves. The event tree cannot be easily made compatible by outsiders to...
I understand it is much cleaner to create this dedicated class, however, I still believe the right place for it is at the `rawlib`. Only in rawlib it will make...
If new types (other than `Short_t`) are introduced for rawsignals, those types should be added somehow also inside `rawlib`. Please, share in case that you foresee another **use-case** where you...
Should `TRestSignalAnalysis` be renamed to something different such as `TRestTimeSignalAnalysis`, `TRestPulseShapeAnalysis` or `TRestWaveFormAnalysis`? `TRestSignal` it is quite generic and it might be used in an statistical case, such as it...