Javier Galan
Javier Galan
In principle it should compile also with ROOT 6.22, why it doesn't? We should try to encourage the use of a particular version, e.g. the one defined by the script...
Shall we close this issue?
Probably the methods on `TRestDetectorSignal` should be just removed. The methods you mention make sense only in the domain of raw-signal processing. Actually, even if it is named signal, the...
> * Speed up data processing by extracting different parameters such as baseline, baselineSigma, threshold integral, risetime, maxPeak and so on using a single loop (funcion). This is already done...
> * The new class or namespace for signal processing should lie inside framework since I believe it should be generic for different libraries (`rawlib` `detectorlib` and `connectorslib`) However, those...
> * Implement generic methods for signal processing that should be agnostic of the original signal event. Agnostic? I imagine these methods will receive as argument a `std::vector `, right?...
Perhaps some of the methods inside `TRestDetectorSignal` should be moved to `TRestRawSignal`. Several methods there date from long time ago when we didn't have yet a `TRestRawSignal`.
> Not necesary, one can think into perform the analysis of the smoothed signal, which is actually my problem. I would like to perform the analysis after signal smoothing and...
> We can keep the same funcions as before for signal processing, but I think we should add generic methods (functions) rather than processes. The generic methods are implemented inside...
I agree with those statements, but not with the latest one. We should keep libraries independent one from each other, all inter-dependencies should be kept in `connectors lib`. There is...