James

Results 20 issues of James

There's a subtle difference in the `round` filter's behaviour when using Ruby 3.1, vs Ruby 2.7. Specifically, when the input value is a float (or anything that gets converted to...

Noting that [documentation](https://shopify.github.io/liquid/tags/iteration/#cycle) for the `cycle` tag only mentions cycling through lists of strings, and [existing integration tests](https://github.com/Shopify/liquid/blob/3de1db3c3a04f413897a7d0a879842143650500b/test/integration/tags/standard_tag_test.rb#L259) cover cycling through lists of integers, is the behaviour demonstrated by the...

BreaksCompatibility

This pull request fixes #1519 by offering an alternative method for generating context keys for the `cycle` tag when using "simple syntax". Rather than using a string representation of objects...

cla-needed

The `base64_decode` and `base64_url_safe_decode` filters don't seem to handle Unicode characters (or any non ASCII data) well. For example. Ruby version 2.5.5 Liquid version 5.0.2 (unreleased) ```ruby require 'liquid' source...

This pull request fixes #79 by not building a `set` from a render context's local namespace values when calculating its size. I'm not sure what I was thinking there 😞....

Recent [commits to the reference implementation](https://github.com/Shopify/liquid/pull/1616/files) have highlighted an incompatibility in the way we handle `{% break %}` and `{% continue %}` tags that appear outside of a `{% for...

wontfix
incompatibility

While Python Liquid's error messages do contain template names and offending line numbers where possible, there is room for improvement, especially for expressions that span multiple lines. The error message...

version 2

Many filters built in to Liquid will automatically convert a string representation of a number to an integer or float as needed. When converting integers, Ruby Liquid uses [Ruby's String.to_i...

wontfix
incompatibility

Python liquid will successfully parse a chained identifier containing a bracketed index or identifier, followed immediately by another identifier, with no separating dot. ```liquid {{ products[0]title }} ``` Ruby Liquid...

future

In addition to `to_liquid_value` (allows drops to behave like a Liquid primitive value inside some expressions), Ruby Liquid uses `to_number` to allow drops to work with filters that expect numbers...

documentation