liquid icon indicating copy to clipboard operation
liquid copied to clipboard

Improve template names and line numbers in error messages

Open jg-rp opened this issue 2 years ago • 1 comments

While Python Liquid's error messages do contain template names and offending line numbers where possible, there is room for improvement, especially for expressions that span multiple lines.

The error message format implemented in LiquidScript seems more readable, and LiquidScript keeps track of the starting index of each token in template source text, rather than a line number, resulting in more accurate error messages.

jg-rp avatar Apr 22 '22 17:04 jg-rp

I consider chumsky / ariadne error reporting for parser to be the best out there right now: https://github.com/zesterer/chumsky

janwirth avatar Jul 16 '22 18:07 janwirth