Jean-François B.
Jean-François B.
> An additional, related question: the `id1` hyperlink target previously emitted for the `figure` is now placed into a LaTeX `\phantomsection`; is that something we should be concerned about? I...
Off-topic: `basic.css` makes it so that `¶` headerlinks are made visible on `hover` for table captions, but not so for figure labels. > Where exactly is the `id1` placed? On...
> This is probably due to another recent commit: > [r10152](https://sourceforge.net/p/docutils/code/10152/) c We saw the modification in LaTeX output already at revision `10151`.
> This is probably due to another recent commit: > [r10152](https://sourceforge.net/p/docutils/code/10152/) changes the LaTeX writer to no longer ignore "ids" in inline elements. [Inline elements](https://docutils.sourceforge.io/docs/ref/doctree.html#inline-elements) with non-empty ["ids" attribute](https://docutils.sourceforge.io/docs/ref/doctree.html#ids) will...
> Has HTML actually dropped the identifier `id1`? Yes it has.
@gmilde We will fix the wording of the test later, thanks for explanations. As per the `visit_target()` from Sphinx LaTeX writer it has indeed a more complex logic. Here is...
It seems the source of our problems is in ``` if node.get('refid'): prev_node = get_prev_node(node) if isinstance(prev_node, nodes.reference) and node['refid'] == prev_node['refid']: # a target for a hyperlink reference having...
For what it is worth if I replace `pass` by `return` in the `visit_target()` of LaTeX writer at the location mentioned in previous comment, all our tests pass [^1] and...
@gmilde I posted my comment prior to having seen yours, sorry. > What would be the test results with this simple change? All our tests pass. With Docutils 0.21.2 a...
> So a quick resolve would be `s/pass/return` but I would prefer confirmation by some competent maintainer. I wrote that prior to having seen @gmilde suggestion to do that :flushed:...