Jesse Duffield
Jesse Duffield
I think a struct works better, that way we have strong typing. I made the decision to switch the i18n stuff to a struct and it's already proven really helpful...
This is totally do-able: we can just copy the approach that lazygit uses: https://github.com/jesseduffield/lazygit/blob/master/pkg/config/user_config.go Any takers?
You could run the command in a shell like `sh -c "my command"`. Thoughts?
Right you are @hugalafutro: as of v0.20.0 we only show the last hour of logs for a given container (see commit here: https://github.com/jesseduffield/lazydocker/commit/0b7017150c7cf0534c71203a53c2ff0f608e459c). This is configurable: you can set: ```yml...
I've got a WIP PR up for making this stuff visible and configurable from within the app https://github.com/jesseduffield/lazydocker/pull/406
I agree, we ought to run all custom commands in a shell so that things like $(pwd) can be evaluated. We do that currently with lazygit
The place we could update is [here](https://github.com/jesseduffield/lazydocker/blob/master/pkg/gui/custom_commands.go#L55). In lazygit we have a NewShell function which takes a command and wraps it in a shell invocation (see [here](https://github.com/jesseduffield/lazygit/blob/master/pkg/commands/oscommands/cmd_obj_builder.go#L54)) so we can...
go ahead @gusandrioli :)
The home key part of this is fixed in https://github.com/jesseduffield/lazydocker/pull/378
I'm happy to accept a PR to address this issue