Karsten Jeschkies

Results 92 comments of Karsten Jeschkies

@lfelipevaca thanks for your contribution. Would you mind addressing Michel's comments?

This is really interesting indeed. I would have expected a minimal version like godoc. However, Jsonnet libs don't have a predefined structure so it makes sense to leave this up...

Ah. I didn't know that bit was already there.

Hm, but toIteraable.zipWithIndex should create just another Iterable. So there should not be much more usage. I need to use grouped etc to save to the database in batches. I...

Okay, I dug a little into the code. So far there is hardly any chance to build an iterator. XMLSource calls WikipediaDumpParser which receives the function and applies this function...

If I am not mistaken Source or XMLSource should extend Iterable and not Traversable: ``` XMLSource(...) extends Iterable[WIkiPage] { val wikiParser = new WikipediaDumpParser(....) def iterator = new Iterator {...

[This](https://github.com/blacklab/extraction-framework/compare/iterable-source) is what I have now. So far there has to be a cast: ``` source.asInstanceOf[XMLReaderSource] .iterable .view .flatMap { (p: WikiPage) => try Some(parser(p)) catch { case _: Throwable...

:wave: I'm not sure if the network labels have any influence here since you don't seem to filter on them. Did you try in a different networking mode?

> Although I feel that Nomad needs its own discovery config. I tend to agree. However, as Promtail inherits Prometheus' service discovery I believe it should be [Consul SD](https://prometheus.io/docs/prometheus/latest/configuration/configuration/#consul_sd_config). Could...

> Could this be related? Aah yes. I vaguely remember that containers must have a port to be discovered. We leverage the service discovery from Prometheus. It makes sense that...