Karsten Jeschkies
Karsten Jeschkies
We are going to add tests before the merge.
@Praveen2112 thanks for this thorough review. There was some great feedback. I've reacted with :+1: to everything I've addressed. The last open question is on the timestamp as a function...
> How is timestamp is represented in Loki ? It depends where. Most of the time it's the Prometheus' [model.Time](https://github.com/prometheus/common/blob/main/model/time.go#L45) which wraps a 64bit int as milliseconds since epoch. Sometimes...
I'm unsure how you would like to have the types documented. I've used the `DESCRIBE OUTPUT` query and result now. It's a little verbose IMHO. It would help if you...
@tucksaun could you resolve the conflicts?
@tucksaun I'm sorry. I've switched teams and have missed GitHub notifications. > I would have loved to have a unified x64 and arm64 build but apparently Docker drivers does not...
I'm fine with landing this but as I understand we would not be able to publish the ARM Docker image as it would override
So @trevorwhitney has been working on the new release process. I don't know if it changed the way the Docker driver was released. I refer to him for reviewing this.
> Start with a DONE line that has counts of tests pass/fail/skipped/error/total. Followed by sections for errors, then failed output , and finally skipped test output. That sounds pretty good...
Thanks it worked. Except that I had to correct the second line to `theme =`.