loki icon indicating copy to clipboard operation
loki copied to clipboard

lambda-promtail: Add support for getting loki credentials with secret…

Open lfelipevaca opened this issue 3 years ago • 2 comments

… manager

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Checklist

  • [x] Documentation added
  • [ ] Tests updated
  • [x] Is this an important fix or new feature? Add an entry in the CHANGELOG.md.
  • [ ] Changes that require user attention or interaction to upgrade are documented in docs/sources/upgrading/_index.md

lfelipevaca avatar Sep 15 '22 10:09 lfelipevaca

./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki

Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell.

+           ingester	0%
+        distributor	0%
+            querier	0%
+ querier/queryrange	0%
+               iter	0%
+            storage	0%
+           chunkenc	0%
+              logql	0%
+               loki	0%

grafanabot avatar Sep 15 '22 10:09 grafanabot

this change implements the feature requested in the following issue

https://github.com/grafana/loki/issues/7169

lfelipevaca avatar Sep 15 '22 10:09 lfelipevaca

Hi! This issue has been automatically marked as stale because it has not had any activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project. A stalebot can be very useful in closing issues in a number of cases; the most common is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

  • Mark issues as revivable if we think it's a valid issue but isn't something we are likely to prioritize in the future (the issue will still remain closed).
  • Add a keepalive label to silence the stalebot if the issue is very common/popular/important.

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task, our sincere apologies if you find yourself at the mercy of the stalebot.

stale[bot] avatar Nov 02 '22 07:11 stale[bot]

@lfelipevaca Thanks for your contribution. Can you check the review comments and rebase? It's looking fine otherwise.

MichelHollands avatar Nov 08 '22 10:11 MichelHollands

@lfelipevaca thanks for your contribution. Would you mind addressing Michel's comments?

jeschkies avatar Jan 18 '23 11:01 jeschkies

@lfelipevaca Are you still interested in getting this done? The lambda-promtail code change quite a bit in the meantime. Would you mind rebasing your branch and addressing @MichelHollands 's comments?

chaudum avatar Feb 27 '23 09:02 chaudum

I'm closing this one due to inactivity.

MasslessParticle avatar Mar 31 '23 17:03 MasslessParticle

Hello, I'm interested in this change. Would it be possible to reopen it so that I can finish what's required in the PR?

SSE69 avatar Jun 10 '24 08:06 SSE69