trino icon indicating copy to clipboard operation
trino copied to clipboard

Document Loki connector result types

Open jeschkies opened this issue 6 months ago • 5 comments

Description

The original Loki connector release was missing a description of the result types of a metric query. This changes adds them.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required. ( ) Release notes are required. Please propose a release note for me. ( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

jeschkies avatar Jun 02 '25 11:06 jeschkies

I'm unsure how you would like to have the types documented. I've used the DESCRIBE OUTPUT query and result now. It's a little verbose IMHO. It would help if you could point me to an example on how to document the output type.

jeschkies avatar Jun 03 '25 14:06 jeschkies

A list-table similar to

https://github.com/trinodb/trino/blob/master/docs/src/main/sphinx/connector/postgresql.md?plain=1#L136

and we dont need the example query but if you want to keep it thats fine as well. Just add it after the table.

mosabua avatar Jun 04 '25 05:06 mosabua

I don't think we should add another list-table. We already have https://trino.io/docs/current/connector/loki.html#loki-to-trino-type-mapping

ebyhr avatar Jun 05 '25 05:06 ebyhr

I don't think we should add another list-table. We already have https://trino.io/docs/current/connector/loki.html#loki-to-trino-type-mapping

Oh .. I totally forgot .. what is the PR trying to achieve then @jeschkies .. seems like all the needed info is there already.

Maybe we just need to tweak the wording in the title of that table and add some more info there.

mosabua avatar Jun 06 '25 02:06 mosabua

I chatted with @jeschkies as part of the TCB work .. I think we can close this PR .. can you confirm @jeschkies ?

mosabua avatar Jun 13 '25 05:06 mosabua

Please feel free to reopen if you continue the work.

ebyhr avatar Jun 21 '25 00:06 ebyhr