Jerome Kelleher

Results 799 comments of Jerome Kelleher
trafficstars

Thanks for the detailed response @akhmerov, this is very helpful! I agree it would be quite a lot of extra complexity and its debatable whether it's worth it.

> By the way, the path_length function (#2249 #2259) is maybe a little too constrained: if the tree has more than one root, the outputs is always inf I don't...

We are doing something similar with the ``TreeSequence.reference_sequence``, where it returns None if it's not defined, FWIW

That sounds like it could be quite messy - we wouldn't want to have something like ```python table.metadata_schema == None # True table.metadata_schema is None # False ``` Unless the...

It'd be helpful to list out the functions that we want here. Anyone fancy going through the API and see where it makes sense to add ``individuals``? (I suppose a...

> Does it make sense to deprecate arguments named "samples" and replace them with "sample_nodes" and "sample_individuals"? I don't know if I'm such a fan of this - I don't...

It's a good idea, but it'll take a while to sort out the details (and we have a lot of stuff that needs to be finished now).

SGTM. What happens when we have more than 2 alleles?

FWIW, I've found the ``/usr/bin/time`` approach to be robust and reliable. The only slightly annoying thing is that you need GNU time, which mac users have to jump through some...