Jeremy Evans

Results 136 comments of Jeremy Evans

I updated the PR to raise an error in #initialize if there should be signed data but there is not.

@rhenium I updated PKCS7.read_smime to raise the same error.

Where do the `post` and `patch` methods come from? They aren't in minitest or rack. Maybe in rack-test? Are you using an old version of rack-test (before rack-test 2.0.0)? Can...

@nurse @duerst Could you review this? Now that #7287 was merged, we definitely want the implementation to match the documentation.

@ko1 For all of these cases: ``` super(arg, *ary) super(arg, *ary, &block) super(*ary, **kw) super(*ary, **kw, &block) super(*ary, kw: 1) super(*ary, kw: 1, &block) f(*ary, **kw, &block) ``` Previously, the...

@kddnewton Thanks for checking. I don't think I have time to pair, but if you can post a diff to update the prism compiler to fix this issue, I'd definitely...

> > [jeremyevans](https://github.com/jeremyevans) requested a review from [k0kubun](https://github.com/k0kubun) [4 minutes ago](https://github.com/ruby/ruby/pull/9477#event-11449566811) > > I'm not sure how I'm relevant to this change. Are you asking me to add YJIT/RJIT support...

Only failure is TravisCI on ppc64le Linux, where it passed test-spec and test-all, but not test: https://app.travis-ci.com/github/ruby/ruby/jobs/616119319#L2006 (with no output)