Jeremy Evans

Results 131 comments of Jeremy Evans

That approach sounds good. I'll work on an implementation and tests next week.

OK, I have an implementation ready for review. I've tested it with one of my small apps (~5 views), with some updates to Roda and Erubi, and it helped find...

@judofyr Have you had a chance to review this? I'm not sure about including the scope class and local keys in the file name. Almost all templates would just compile...

> > Have you had a chance to review this? > > I've been a bit busy so I haven't been able to test out the code locally yet. Hoping...

I've rebased this against the master branch, and added support for the Erubi template to use this. This can decrease strings allocated during template rendering, and allows for additional optimizations...

@judofyr This is something I plan to merge unless you object.

Taking a look now. I'm guessing the method issue is because we are not using the singleton class. Not sure about the hanami scope issue at this point.

The issue with the method definition is because in 2.0.10, `foo` is defined in `Tilt::TOPOBJECT` (which is `Tilt::CompiledTemplates` in Ruby >2.0). To fix this and still work on Ruby 2.7...

The hanami issue I'm not sure about, I would need the content of the template that is failing, the scope it is being executed on, and which constants are defined...

These issues show that the new behavior is not backwards compatible in all cases and probably cannot be made backwards compatible in such cases. However, the new behavior is necessary...