Jeremy Evans

Results 131 comments of Jeremy Evans

I'm on the Bundler slack (among other things, that is where rack development is coordinated). I think I can send you an invite to that if you are interested. Looks...

This has also been rebased after the switch to minitest/spec.

I submitted #376 to implement `Mapping#unregister(*extensions)`

@waghanza The `rack/server` issue is because that code was extracted to a gem named `rackup` when `rack` 3 was released. So if you add the `rackup` gem, it should continue...

Camping says it supports rack 1+, but it doesn't look compatible with rack 3 (https://github.com/camping/camping/blob/master/lib/camping-unabridged.rb#L16 shows uppercase header, when all headers must be lowercase in rack 3). This is known...

If anyone has experience with addr2line, this could definitely benefit from a review. Unfortunately, I am not qualified to review these changes.

@nobu Thank you for your review. I didn't realize the difference before. That makes the patch much more involved, since it requires adding support for a new transcoder. Hopefully the...

@nobu It appears that `newline: :crlf` converts on read and not just on write, but only on Windows. Is this a bug, or is this expected behavior on Windows?: ```...

1 failure, but it doesn't seem related to this change: https://github.com/ruby/ruby/pull/4590/checks?check_run_id=2879532690#step:15:215

As the linked issue indicates, `SERVER_PROTOCOL` should now be used for the HTTP version used for the request. For backwards compatibility with existing applications, which often use `HTTP_VERSION`, since that...