Jeremy Wohlwend

I don't know if this use case legitimizes changing the interface.. You could just create a new Embedder-style object for you use case. Could you provide an example or two...

Ok this use case makes sense, but I don't understand the change you are requesting. Embedding and encoder are already separated. Embedder links both of them, so you could very...

Provided we use version > 0.16.0

@nmatthews-asapp I like the idea. I can try to make a PR for it

100%. We should add a test suite to make sure that is the case, always

we could also consider just computing the metrics on a per batch level during training and logging that, but then things like dropout will affect the training metrics. That's true...

What do you propose to fo with the training and validationloss over the whole dataset? Since people generally use torch loss objects which won't have the "incremental" logic?

Yeah I think a boolean on the Trainer and Evaluator as you've suggested offline makes sense to me. Will work on that after #83

@cle-ros That s a sweet idea. I'll think about it after the next release!

The sonar error is due to the fact that i had to fix some flake8 errors across the code base. Should be ignored