flambe icon indicating copy to clipboard operation
flambe copied to clipboard

Improving error messages in case of double key in config

Open iitzco-asapp opened this issue 5 years ago • 2 comments

Is your feature request related to a problem? Please describe. When certain configs have a duplicate key in the config, then flambe fails with:

ruamel.yaml.constructor.ConstructorError: could not determine a constructor for the tag xxxx

I expect this happens with the ones that have a Runnable from an extension as top level object in the config

Describe the solution you'd like The error message should be clear on what's happening:

The provided configuration file contains duplicated keys 'xxxx'

iitzco-asapp avatar Aug 23 '19 21:08 iitzco-asapp

@jeremyasapp we validated this is not the case with our current ruamel.yaml usage in v0.5, yes?

nmatthews-asapp avatar Mar 03 '20 16:03 nmatthews-asapp

Provided we use version > 0.16.0

jeremyasapp avatar Mar 03 '20 17:03 jeremyasapp