Jeremy Daley

Results 9 comments of Jeremy Daley

@3imed-jaberi Who has the ability to merge this?

@EltonZhong I'm seeing the same when the byteLength is zero

@nsimmons Can you please consider merging this PR? Thanks!

@keymandll I know that it's definitely not working perfectly fine in my case, where a `HEAD` request is proxied. A `HEAD` response does not include a body, so what @EltonZhong...

@keymandll I really don't think Node version is of consequence. Can you please check my PR here: https://github.com/nsimmons/koa-better-http-proxy/pull/54 If you remove the `byteLength` check from my branch and run the...

@keymandll I appreciate the interest and feedback. The `.nvmrc` of the project is set to `v14.15.4`, but even testing with your Node version, I get the same result: ![image](https://user-images.githubusercontent.com/77355440/221252803-58a3153c-fe17-4f03-8897-735c24abe65a.png) I'm...

@keymandll I just updated my test btw. Took me a minute to figure out `sinon` spying, but I've confirmed test failure when I remove the `if` condition.

You can see here that `msal-browser` is specifically emitting a `null` value for the `payload` param when there's an error: https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/b560a06b7389f964fcc78092e10df42e5a74d2de/lib/msal-browser/src/controllers/StandardController.ts#L434 I would like to know if there's a specific...

As I started digging through the built-in JSON reporter more, I _think_ I'm seeing that `TestCase.id` doesn't persist through retries, and perhaps that's one reason the `testPath()` concatenation is necessary...