koa icon indicating copy to clipboard operation
koa copied to clipboard

Added exports.default to package.json

Open daleyjem opened this issue 3 years ago • 2 comments

Per NodeJS documentation on the package.json exports object, there seems to be a need for a fallback default key: https://nodejs.org/api/packages.html#conditional-exports

Additionally, I'm seeing things like eslint fail to resolve until a default key has been specified. I've not dug any further into why, but I think some default should be defined until more options should later be added.

daleyjem avatar Jan 10 '22 20:01 daleyjem

Codecov Report

Merging #1630 (ec8de58) into master (8c1dd48) will not change coverage. The diff coverage is n/a.

:exclamation: Current head ec8de58 differs from pull request most recent head e5617c1. Consider uploading reports for the commit e5617c1 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1630   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files           5        5           
  Lines         507      507           
  Branches      142      142           
=======================================
  Hits          505      505           
  Misses          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8c1dd48...e5617c1. Read the comment docs.

codecov[bot] avatar Jan 10 '22 20:01 codecov[bot]

@3imed-jaberi Who has the ability to merge this?

jeremy-daley-kr avatar Oct 11 '22 14:10 jeremy-daley-kr