Jeff Vestal

@dev2049 Definitely. It might be a couple days as I'm traveling this week but I'll get something in there.

I'm not able to assign this to myself but the PR links this issue

I can add in the ability to use a url (the elasticsearch url) to the connection object rather than the cloud_id. Would that work for you @lemig ?

That should work. I'll take a look at it soon.

@lemig PR was merged. ``` # Create Elasticsearch connection es_connection = Elasticsearch( hosts=['https://es_cluster_url:port'], basic_auth=('user', 'password') ) # Instantiate ElasticsearchEmbeddings using es_connection embeddings = ElasticsearchEmbeddings.from_es_connection( model_id, es_connection, ) ```

Adding any examples you have to the notebook would be very helpful! I'll try to take a look over the code this weekend

@benwtrent do you have time to do another review? I think I addressed all the issues I removed ElasticKnnSearch as a subclass but tried to align the methods to be...

@baskaryan Somehow I picked up 27 other files to change in this PR. Are you able to take a look? It should just be the `langchain/vectorstores/elastic_vector_search.py` file

Langchain repo underwent a large reorg. Closing this PR in favor of https://github.com/langchain-ai/langchain/pull/8180

need to add vector field option for knn and vector field and query field for hybrid