langchain icon indicating copy to clipboard operation
langchain copied to clipboard

Allow query field to be passed in ElasticKnnSearch.knnSearch

Open jeffvestal opened this issue 1 year ago • 1 comments

System Info

The _default_knn_query takes field arg to specify the field to use when performing knn and hybrid search.

both knn_search and hybrid_search need to allow that to be passed in as an arg and pass it to _default_knn_query

I'll make the update

cc: @hw

Who can help?

No response

Information

  • [ ] The official example notebooks/scripts
  • [ ] My own modified scripts

Related Components

  • [ ] LLMs/Chat Models
  • [ ] Embedding Models
  • [ ] Prompts / Prompt Templates / Prompt Selectors
  • [ ] Output Parsers
  • [ ] Document Loaders
  • [X] Vector Stores / Retrievers
  • [ ] Memory
  • [ ] Agents / Agent Executors
  • [ ] Tools / Toolkits
  • [ ] Chains
  • [ ] Callbacks/Tracing
  • [ ] Async

Reproduction

Try to search a field other than vector, can't do it

Expected behavior

Pass a qeuery_field value to search over a different field name other than the default vector

jeffvestal avatar Jun 02 '23 20:06 jeffvestal

need to add vector field option for knn and vector field and query field for hybrid

jeffvestal avatar Jun 03 '23 01:06 jeffvestal

Hi, @jeffvestal! I'm Dosu, and I'm here to help the LangChain team manage their backlog. I wanted to let you know that we are marking this issue as stale.

From what I understand, you opened this issue requesting the ability to pass a query_field argument to the knn_search and hybrid_search functions in order to search over a different field name other than the default vector. However, there hasn't been any further activity or comments on this issue since you opened it.

Before we close this issue, we wanted to check with you if it is still relevant to the latest version of the LangChain repository. If it is, please let us know by commenting on the issue. Otherwise, feel free to close the issue yourself or it will be automatically closed in 7 days.

Thank you for your understanding and contribution to the LangChain project!

dosubot[bot] avatar Sep 02 '23 16:09 dosubot[bot]