Jeffrey Walter

Results 131 comments of Jeffrey Walter

binary(1) should probably be converted to bytea(1). The defined behavior is pretty much identical between the two: https://dev.mysql.com/doc/refman/5.0/en/binary-varbinary.html http://www.postgresql.org/docs/9.0/static/datatype-binary.html

@ubogdan here's a stack trace from a similar failure I'm encountering: ``` 2022/06/16 23:58:41 Generating sql.NullBool 2022/06/16 23:58:41 Skipping 'sql.NullBool', recursion detected. panic: runtime error: invalid memory address or nil...

I suspect `schema` is `nil` in this code: ``` func (parser *Parser) getRefTypeSchema(typeSpecDef *TypeSpecDef, schema *Schema) *spec.Schema { _, ok := parser.outputSchemas[typeSpecDef] if !ok { existSchema, ok := parser.existSchemaNames[schema.Name]

I would also note that the mathematical solution is O(1), not O(n) like the currently listed solution.

This library is also missing the `retry` semantics and the handling of the `Last-Event-ID` doesn't seem right.

I've used [this Python sse client library](https://github.com/btubbs/sseclient/blob/master/sseclient.py) in production code and have looked at it's code quite a bit. It seems to follow the standard pretty closely and would be...

Going to leave this open since retry isn't fully implemented.

You might try putting a `.` at the end of your DNS entry. i.e., `some.hostname.com.`

@Kerl1310 thank you so much! I REALLY appreciate your contributions. Is there anything we need to do to get your tests hooked up to a github action?

I merged your changes and pushed a new release commit, but didn't see any indication that the tests ran. Can you check in master and see if it's running?