arlo icon indicating copy to clipboard operation
arlo copied to clipboard

Published 20 hours ago • verified publisher icon jeffreydwalter

Add unit tests - 100% coverage would be ideal.

Open jeffreydwalter opened this issue 6 years ago • 8 comments

Would be nice to have automated tests so we know the API is performing.

jeffreydwalter avatar Dec 08 '17 16:12 jeffreydwalter

Added some initial unit test code to get this underway. Happy to implement more over time if the initial implementation passes review

Kerl1310 avatar Jan 11 '21 14:01 Kerl1310

@Kerl1310 thank you so much! I REALLY appreciate your contributions. Is there anything we need to do to get your tests hooked up to a github action?

jeffreydwalter avatar Jan 11 '21 19:01 jeffreydwalter

Theres a GitHub actions CI file included which should just work once it's merged with any luck. If not I can fix it if there are any issues

Kerl1310 avatar Jan 11 '21 20:01 Kerl1310

I merged your changes and pushed a new release commit, but didn't see any indication that the tests ran. Can you check in master and see if it's running?

jeffreydwalter avatar Jan 11 '21 20:01 jeffreydwalter

Looks like you set it up to only run on pull request? Am I reading this right?

jeffreydwalter avatar Jan 11 '21 21:01 jeffreydwalter

@jeffreydwalter I added support for running on push to master as well. Thanks again! I REALLY appreciate your contribution and am happy for anything else you feel like adding!

jeffreydwalter avatar Jan 11 '21 21:01 jeffreydwalter

Looks like the CI is running but it's having issues with the imports so the build is failing

Kerl1310 avatar Jan 12 '21 20:01 Kerl1310

Yep! I was trying to figure it out, but don't really know how to fix it. If you have a few cycles to take a look I would be forever grateful!

jeffreydwalter avatar Jan 12 '21 20:01 jeffreydwalter