Jeff Posnick
Jeff Posnick
FYI: we have some thoughts on how to deal with offline analytics moving forward in the Workbox project at https://github.com/GoogleChrome/workbox/issues/3055 It's likely that we're going to encourage folks to use...
Historically we've been running staging in our presubmit, so I just left that as-is. Staging takes 6 minutes. I'll add a commit to flip it to production and we can...
So, it's 18 minutes for the prod build, vs. 6 minutes for the staging build. A staging build will be sufficient to catch any of the 11ty-related errors we've run...
> A staging build will be sufficient to catch any of the 11ty-related errors we've run into lately. I did want to acknowledge that a staging build would _not_ have...
Yes, this should re-run each time there's an additional commit. It's configured for `on: pull_request`, and as per the [docs](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request): > Runs your workflow when activity on a pull request...
CC: @rachelandrew and @mattletford, as I believe this was migrated over as part of https://github.com/GoogleChrome/web.dev/pull/7551
Hah—stalebot wants to mark this as stale. Do you want this merged, @devnook?
I believe the original author was @adactio, but I'm not sure who is responsible for maintenance/fixes for this content. Assigning to @rachelandrew for triage.
Looking at https://github.com/GoogleChrome/web.dev/pull/6975, I believe this has to do with changes implemented in support of dark mode. Though arguably this specific example doesn't look ideal in dark mode, either: Hopefully...
Rather than changing the slugs, it may be preferable to update the `ScrollSpy` code to properly escape those `id` values: https://github.com/GoogleChrome/web.dev/blob/0856d43c327973b51d7407a60062ed7b3e3136c0/src/lib/components/ScrollSpy/index.js#L83-L88