Jeff Posnick

Results 297 comments of Jeff Posnick
trafficstars

Given that the routing logic is implemented in Python, it would be somewhat of a manual process to translate that into something that a JavaScript-based service worker could make use...

FWIW, the "fake" scope that won't result in the SW controlling any pages approach is what the [Firebase Messaging SDK](https://firebase.google.com/docs/cloud-messaging/js/client) uses. The main drawback is that the [service worker update...

`const availableWorker = reg.installing || reg.waiting || reg.active;`, used in that context, should reliably give you access to an instance of the service worker. The only thing to decide on...

I'm not 100% sure on the mechanisms for developers to upgrade, and what the "before" and "after" service workers generally look like, so I can't fully address your `Migration to...

That's interesting—I've never had to use `Service-Worker-Allowed`, so I wasn't aware of that nuance around keeping the header whenever you serve the response. Another relevant header is `Service-Worker: script`, which...

Not every CDN supports [CORS](https://developer.mozilla.org/en-US/docs/Web/HTTP/CORS), so it would introduce compatibility issues with those CDNs if the `crossorigin` attribute were added unconditionally for every cross-origin URL. Neither JavaScript nor CSS resources...

It would definitely break things if we unconditionally added the `crossorigin="anonymous"` attribute to all `` tags, or all `` tags for `script` resources. Any third-party script that is hosted on...

CC: @housseindjirdeh

Can you try things out with the [`v3.0.0` alpha releases](https://github.com/GoogleChromeLabs/preload-webpack-plugin/releases/tag/v3.0.0-alpha.1) and let me know if you run into any issues there? ``` $ npm install --save-dev preload-webpack-plugin@next ```

FWIW, The v3 branch has a new check for this, and will display in a meaningful error message when this happens: https://github.com/GoogleChromeLabs/preload-webpack-plugin/commit/89f6495dcd0f4a17db85566ebd3357f4375a6bce#diff-1fdf421c05c1140f6d71444ea2b27638R123