Jeff Posnick
Jeff Posnick
If you run your own `babel` transpilation process after Workbox generates a service worker, you have control over adding in additional configuration options, like including the https://babeljs.io/docs/en/babel-plugin-transform-runtime or https://babeljs.io/docs/en/babel-plugin-transform-regenerator plugins...
When you set `babelPresetEnvTargets`, there's a single transpilation performed, and a single service worker file output. You can think of it as meeting the requirements of the "lowest common denominator"...
`InjectManifest` mode will create a `childCompiler` instance under the hood, and a lot of of the webpack configuration is inherited from the main, "parent" compilation. I've [heard](https://medium.com/@prateekbh/my-experience-writing-a-webpacks-child-compiler-plugin-a1237c175947#0f70:~:text=It%20did%20kinda%20felt%20weird%20though,to%20be%20applied%20on%20my%20compiler.) that the `plugins`...
Hey all. Sorry for not updating this for a while. @phil-w, the [`babelPresetEnvTargets` setting](https://developers.google.com/web/tools/workbox/reference-docs/latest/module-workbox-webpack-plugin.GenerateSW#:~:text=babelPresetEnvTargets) is available when you're using the `GenerateSW` plugin. If you're using the `InjectManifest` plugin, then any...
Hello @denieler—how are those new releases detected? Are you calling `wb.update()` after each deployment of a new service worker, keeping the same page open? And which browser are you seeing...
Oh, that's an excellent point—you're correct in that we need to cut a new release for that and a couple of other bug-fix PRs that have been merged recently. CC:...
We're looking to get Workbox v6.1.3 out with these related changes early next week. Please give it another try then.
Workbox v6.1.5 (which ended up being the next release's version number) includes the changes in #2787. Hopefully things work as expected for you with that version.
I was digging into this a bit and it sounds like it could be the same thing as https://github.com/archiverjs/node-archiver/issues/288 It's unfortunate that the rejected promise within the `gulp` task leads...
It turns out that the `archiver` module already returns a promise from its `finalize()` method: https://github.com/archiverjs/node-archiver/blob/d43f922abcf2e9b407fa45591e0e8665fc0f8786/lib/core.js#L762-L795 (This isn't mentioned in [the docs](https://archiverjs.com/docs/Archiver.html#finalize), but I filed a PR to fix that:...