Jeffrey Paul

Results 467 comments of Jeffrey Paul

Per [yesterday's bug scrub](https://wordpress.slack.com/archives/C04L4KCUB/p1648040434425739), @georgestephanis feels the sanitize string is reasonable and could be good to merge, but is not familiar with `filter_callback` and not positive if core code style...

Per [yesterday's bug scrub](https://wordpress.slack.com/archives/C04L4KCUB/p1648040434425739), @georgestephanis is going to give this a review but there's some minor whitespace tweaks around line 80 inside the function call and also not entirely certain...

@kasparsd any thoughts on a review of this PR and whether it's ready for consideration in v0.8.0?

Per [yesterday's bug scrub](https://wordpress.slack.com/archives/C04L4KCUB/p1648040434425739), given our narrow focus in 0.8.0 on the U2F deprecation we're going to punt this to a future release but note that it is a worthwhile...

@alexclst this is still in need of someone picking up the existing work in the PR and updating based on feedback in https://github.com/WordPress/two-factor/pull/239#pullrequestreview-153752223.

@kasparsd any thoughts on a review of this PR and whether it's ready for consideration in v0.8.0?

Per [yesterday's bug scrub](https://wordpress.slack.com/archives/C04L4KCUB/p1648040434425739), @georgestephanis is in favor of being able to generate QR codes internally but we're going to punt this to a future release (ahead of a core...

@kasparsd any thoughts on a review of this PR and whether it's ready for consideration in v0.8.0?

Per [yesterday's bug scrub](https://wordpress.slack.com/archives/C04L4KCUB/p1648040434425739), we're going to punt this to future release so that we can focus on the U2F deprecation in 0.8.0.

@kasparsd note that this relates to https://github.com/WordPress/two-factor/issues/423#event-6301632114 wherein the next step after removing U2F is the determining the best path forward from here (happy to hear your input there).