Jeff Parsons

Results 82 comments of Jeff Parsons

> Regarding optional coalescing: I view it as in the same domain as defragging the blocks of a disk or garbage collection. That is, it shouldn't be required for correctness,...

I think this might not actually be possible, because `core::ops::Range::contains` doesn't use `Borrow`. Compare: - https://doc.rust-lang.org/stable/std/collections/struct.BTreeSet.html#method.contains - https://doc.rust-lang.org/stable/std/ops/struct.Range.html#method.contains And we would need to be able to pass a `Q` into...

On second thoughts, this limitation only exists because of my current internal representation (and even with it I think I could work around it), so I'm going to re-open this....

My attempts at implementing `Borrow` in ways that would let me work around this keep ending up conflicting with this blanket impl: ```rust impl Borrow for T { ... }...

Hi @Rua, Thanks for getting in touch, and sorry for not replying to this for (_checks_) nearly a year. :neutral_face: As I just mentioned over on [this other issue](https://github.com/jeffparsons/rangemap/issues/62#issuecomment-1416589818), I'm...

Thanks for writing this up, @jasonwhite. I'm definitely open to adding something along these lines. I have some concerns and questions about the API around how it would interact with...

Sweet, thanks @jasonwhite. Now that I've seen your API I do prefer the all-in-one trait approach for callbacks, primarily because I think it will make client code more readable. I'm...

Just to clarify, is this currently "waiting-on-review", to use the rust-lang parlance? Or, conversely, is further review currently blocked on any action from the author?

> @jeffparsons this is waiting on an action on [#1836 (review)](https://github.com/tokio-rs/mio/pull/1836#pullrequestreview-2367086886). We currently don't have the capacity to review a pr of this size, so it needs to be split...

@Thomasdezeeuw Does the proposal in https://github.com/tokio-rs/mio/pull/1836#issuecomment-2441708065 sound okay to you?