Jeff Barczewski

Results 162 comments of Jeff Barczewski

Since we still haven't figured out the issue with getting a build that can combine joi-browser and joi-date-extenstions-browser properly, I went ahead and created `joi-full` which is a universal package...

Thanks for identifying this @riston. I can see if there are ways to improve the situation internally or like you said via dynamically adding and removing logic. Maybe there are...

Thanks for the update @askot. I'll take a look and see what we can do to help this situation. And thanks for the tip about how to reproduce in canary...

I tried running with Canary with limited stack as you mentioned ``` /Applications/Google\ Chrome\ Canary.app/Contents/MacOS/Google\ Chrome\ Canary --js-flags="--stack-size 400" ``` and ran your example with the 100 logics (https://github.com/riston/redux-logic/blob/perf-logic/examples/async-fetch-proc-options/src/users/logic.js) Should...

I was thinking about the issue and I wonder if it could be solved by swapping out the logic stack as you change to different parts of your app? That...

Ok, I can look closely at that example to see what is occurring. Thanks. As for https://github.com/jeffbski/redux-logic/blob/master/src/logicWrapper.js#L39 I am using a share() because all the logics do want to share...

Great @riston that sounds like a winner then. Yes @VitalyChe I can write or show a design of how it will work, that way we can all look at it...

@askot @riston I have an experimental branch that I would like you to try to see if it helps with the limited call stack issue on mobile browsers. I have...

@riston does it prevent the failures you were seeing? I'm still planning on doing the refactor I mentioned, but I was hoping that this might buy me some time to...

Thanks for responding @tehnomaag with this great summary of your changes. I'll plan to also go through these and understand the details so we might be able to bring these...