Justin Chadwell

@jpadams the markdown linter has now been moved to `github.com/dagger/dagger/dev/markdown` in `main`. The reason for the failure is because of this dependency in the commit you're targeting: https://github.com/dagger/dagger/blob/88d89e8d15ab6ad9ca4043a920d3cd735a6405fd/linters/markdown/dagger.json#L7 This version...

There is a small issue with applying this change - we can't change `KeepGitDir`'s default to `true`. The problem is that Go can't see the difference between a struct field...

Moving this out of the milestone - and into the next release where we can make breaking changes.

> Worth double-checking we still see this. So much has changed that it's not guaranteed to still be true. This still seems to be true - simple script to confirm:...

Nice work so far @grouville :tada: I'm not sure I think we should accept buildkit style refs here. Here's an alternative idea: Here's a suggestion for how we could resolve...

Yup this is common to every SDK, but probably still worth explicitly handling this case of an empty git repo. > it's a normal behaviour I think the proposal is...

Ideally we should version-compat this change - it has the potential to break published modules, so should have a check here.

@wingyplus see https://github.com/dagger/dagger/pull/9118/files#diff-8062ad596c2b352a00e64f30eb9fff7ade878660570bf2c3c5f5aa727dd10496R864 for an example of where I've done this recently. Generally: - If a core function signature changes, you use [dagql views](https://github.com/dagger/dagger/blob/e2be4eaedc36f1c65efcff760cae4d596e323b82/core/schema/container.go#L335-L336) - If you're just changing behavior...

@vito mentions: > Maybe the ReturnError call used a different ctx so the ReturnError request itself doesn't get interrupted, but the session still got torn down anyway

This does seem to have done it, I'm no longer seeing this flake!