Justin Chadwell
Justin Chadwell
Looking through go-prompt, the maintainer seems inactive, so it seems likely we'd probably have to fork if we need changes.
Ahhh we should just get rid of this API - this is actually "working as intended", but it's terribly confusing. `SetSecret` returns a `Secret` - but is doing so lazily...
Hm, okay, yeah you're right :thinking: cc @sipsma We don't have tests for this case, so not hugely surprising that it's broken. Will glance into this at *some* point, but...
This API is now gone :tada: and replaced with secret providers. Very very glad this one is gone!
Rebased this to handle all the changes we've made in the meantime, and also updated to pin the alpine version in places, since this *has* broken things in the past,...
In terms of `dagger upgrade` we can use the functionality added in https://github.com/dagger/dagger/pull/8587 - when you run `dagger upgrade` we should erase-and-recalculate the pins.
> Do we want to support updating just one dependency or everything in the dependencies list? `dagger upgrade` by itself should upgrade all dependencies - but I guess it would...
> * if no version specified, use latest (main? or latest tag?) I don't think you should be able to upgrade to a specific version. That functionality is already covered...
Support for `manifest` is more complex than the other cases, since it requires modifying the manifest, see here from the original PR: https://github.com/docker/buildx/pull/1965#discussion_r1281623654. I remember discussing this internally at some...
As suggested in the call earlier: - Doing this as a deprecation is annoying, because the type rename isn't very fun (module compat can't do this *right* now, and I'm...