Jon Dufresne comments

Results 101 comments of


                                            Jon Dufresne

UnicodeEncodeError "surrogates not allowed" raised when converting utf-16-encoded emoji

Thanks for the report. Do you have a complete HTML document that renders correctly in a browser? Or are you expecting this to render as � (replacement character)?

TypeError in escape_md

I am not able to reproduce this on the latest master. Perhaps this has been fixed and can be closed.

Update Python test matrix (drop EOL Pythons and add new ones)'

Thanks for the review. I've modified the README as suggested. Tests are now green.

Update Python test matrix (drop EOL Pythons and add new ones)'

Since this PR originally went up, there have been new Python releases and now Python 3.4 is EOL. I have updated the test matrix to test all new Pythons.

`rabbitmq_user`: ValueError: need more than 1 value to unpack

I think this might have been fixed in 351d9fb11c09bc3f8f32992679c948a253226032.

Add dill serializer

I think it would be good to add tests similar to the other serializers.

Type hinting

FWIW, I'm in favor of seeing type hints added. Using the comment syntax ensures the code can remain compatible with legacy EOL Pythons.

Type hinting

If you want, you should be able to avoid the `typing` dependency by using the `if False:` trick: ```py if False: from typing import Tuple ``` mypy understands this and...

Rule Idea: Enforce boolean literals for "booleanish" HTML attributes such as aria-hidden

Thanks for the link and moving the ticket. The docs on that rule read: > [When using a boolean attribute in JSX](https://facebook.github.io/react/docs/jsx-in-depth.html#boolean-attributes), you can set the attribute value to true...

feat(eslint-plugin): [no-unnecessary-coercion] add rule

I'd like to throw out another potential case of an unnecessary type conversion: `Object.values(array)`. This is a construct that I have found in my own projects. Once found, I simplify...