Jana Dönszelmann

icon indicating a website link https://donsz.nl icon indicating an email [email protected]

icon company TU delft & Hexcat icon location Delft icon location CSE and CESE lecturer at TU Delft, consultant, research supervisor, and open source contributor

Results 114 comments of Jana Dönszelmann

Bug: Overflow of read/writeptr

The behavior doesn't depend on the platform, we use non-wrapping integers so on overflow we panic in debug mode and technically UB in release mode. On 64 bit platforms, overflows...

Warn on codegen attributes on required trait methods

r? jdonszelmann

Warn on codegen attributes on required trait methods

@JonathanBrouwer could you make a parallel PR that makes this a full error, then we crater that. Or at least I believe we wouldn't see this warning in a crate...

Warn on codegen attributes on required trait methods

@rustbot blocked

Emit `check-cfg` lints during attribute parsing rather than evaluation

@rustbot author

Emit `check-cfg` lints during attribute parsing rather than evaluation

Looks good then I think. @bors r+ rollup

early return on duplicate span lowerings

@rust-timer queue

early return on duplicate span lowerings

@bors try cancel

early return on duplicate span lowerings

@bors2 try @rust-timer queue

early return on duplicate span lowerings

@bors try cancel