Jana Dönszelmann
Jana Dönszelmann
> > First, the hir stats changed slightly. Mostly because Attribute didn't used to be in there. > > I see this line: > > ``` > hir-stats Attribute 128...
@nnethercote well that did it, the file even disappeared from the diff cause they're equal now :blush:
Thanks for the review! I'm actually quite far with refactoring attributes completely, also step two as highlighted in the MCP. I'll address the comments here, but also make a draft...
Sorry Eric, some submodule update to cargo slipped in but nothing actually changed in Cargo
Alright, I promised I'd write this, so finally here we go. I'll also post this same comment [here](https://github.com/rust-lang/rust/issues/131229) to track progress. # Already completed - [x] remove attribute IDs from...
hi! that's right, and I'll also write some things down about it. In general, the new `rustc_attr` crate already contains copious amounts of docs on my own system. Will try...
@rustbot claim
Seems like reasonable changes, also well tested and I like the perf bonus. lemme quickly approve CI and see if miri still passes but then it's ok by me. @NULLx76...
@cdellacqua I'm afraid, however nice, it fails miri. Want to take a look at it?
coverage is no prob for now, that's just a deprecated line in the ci workflow definition