Jana Dönszelmann comments

Results 114 comments of


                                            Jana Dönszelmann

Infrastructure for lints during attribute parsing, specifically duplicate usages of attributes

thanks! let's hope this is the one

Infrastructure for lints during attribute parsing, specifically duplicate usages of attributes

![bors-r-oli](https://images.donsz.nl/bors-r-oli.png)

Infrastructure for lints during attribute parsing, specifically duplicate usages of attributes

@bors r=oli_obk

Rewrite `inline` attribute parser to use new infrastructure and improve diagnostics for all parsed attributes

@rustbot review

Infrastructure for lints during attribute parsing, specifically duplicate usages of attributes

@workingjubilee I'm happy this gets merged but some of those I deliberately didn't r+ yet to wait for this one but this makes sure it work :)

Rewrite `inline` attribute parser to use new infrastructure and improve diagnostics for all parsed attributes

ah shit, broke clippy :sob:

Rewrite `inline` attribute parser to use new infrastructure and improve diagnostics for all parsed attributes

note, there are tests that tests the newly emitted lints during attr parsing. However, it works so well, none of them changed! They are emitted though, but exactly the same...

Rewrite `inline` attribute parser to use new infrastructure and improve diagnostics for all parsed attributes

ugh, the rebase

Rewrite `inline` attribute parser to use new infrastructure and improve diagnostics for all parsed attributes

I think that addresses all the review comments by others @oli-obk :)

Rewrite `inline` attribute parser to use new infrastructure and improve diagnostics for all parsed attributes

@bors r=oli_obk rollup=iffy