Jason DeBacker

Results 152 comments of Jason DeBacker

@rickecon Yes, the tax function estimation is the bottleneck as the data requirements are the largest there (you have a `Calculator` object at each of the cores + other data)....

> We probably need to scatter the Calculator object ahead of time so this will run more smoothly. I didn't post all the output, but it is running great now...

@sebastiansajie I like your fixes to the `output_plots.py.plot_all()` function and the `lambda_labels` (really creative solution there!). Thank you for proposing these. I'd recommend adding the `lambda_labels()` function to `utils.py` as...

@rickecon This branch isn't up to date with the master. It's still a work in progress. I'll sync and then be moving forward with dynamic firms soon. I've got the...

I haven't thought too much more on this. Basically taxes are implemented by making after-tax profits: (1-\tau)(AK^{\alpha}l^{1-\alpha}-wL) - (r + \delta -\tau\delta^{\tau})K, where \tau is the marginal rate on corporate...

The suggestion I make above does not work in with a CRS production function as economic profits are zero. Therefore, the scaling parameter for the average tax rate has no...

@bodiyang, when I run the unit tests on this branch on my machine, I get the following failures: ``` FAILED taxcalc/tests/test_calculator.py::test_itemded_component_amounts[2017-c18300-ID_AllTaxes_hc] FAILED taxcalc/tests/test_calculator.py::test_itemded_component_amounts[2017-c19700-ID_Charity_hc] FAILED taxcalc/tests/test_compare.py::test_itax_compare[True] - ValueError: C... FAILED taxcalc/tests/test_puf_var_stats.py::test_puf_var_stats...

@bodiyang Thanks for the latest commits. Test failures seem to be related to an issue in the latest release of `bokeh` (see [here](https://stackoverflow.com/questions/74280959/attributeerror-unexpected-attribute-plot-width-to-figure-similar-attributes)). Unfortunately, I don't see a solution yet.

@bodiyang Have you pushed all your changes to this branch? I synced and ran tests again locally and still found failures.

@bodiyang Thanks for confirming. I created a new PUF from the most recent `taxdata` and then ran the unit test. All test, except for those using `bokeh` passed, confirming your...