Jason DeBacker

Results 152 comments of Jason DeBacker

@bodiyang Ok, I confirmed my `cps.csv.gz` produced by `taxdata:master` gives exactly the same data as what is in the `cps.csv.gz` file in Tax-Calculator. In `tax data` [PR #412](https://github.com/PSLmodels/taxdata/pull/412), @andersonfrailey notes...

@bodiyang I just opened a PR to your `CBO-baseline` branch which should take care of the test failures here. Please give it a look and merge it in and we'll...

@bodiyang Thanks or merging my PR. It seems there is still one test failure when using `bokeh >= 3.0.0` with a serialization error. I found an [issue related to that](https://github.com/bokeh/bokeh/issues/11800),...

@bodiyang Can you change `environment.yml` to replace `- "bokeh>=1.4.0,

LGTM - thanks @bodiyang!

Closing this issue. If necessary, something like this can be raised over in the [TaxData project repo](https://github.com/PSLmodels/taxdata).

Now using TAXSIM-35 for the validation...

I believe this PR is ready. It adds utilities for testing against TAXSIM 35. It does not update the expected files for 2017-2019 and does not add them for 2020...

Per @MaxGhenis' comment, the code in the `SchR` function is correct (albeit, the values should be parameterized rather than hardcoded -- but that can be opened as a separate issue.

@MaxGhenis It looks like PolicyEngine has this hardcoded as well. Trying to think if a good name if one wants to parameterize this...