OG-Core icon indicating copy to clipboard operation
OG-Core copied to clipboard

[WIP] Dynamic Firms

Open jdebacker opened this issue 6 years ago • 6 comments

This PR replaces the static representative firm with a dynamic representative firm, that maximize the present discounted value of profits. This addition allows for modeling capital adjustment costs and better modeling of business tax policies.

jdebacker avatar Apr 20 '19 00:04 jdebacker

Codecov Report

Merging #457 into master will decrease coverage by 15.93%. The diff coverage is 92.76%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #457       +/-   ##
===========================================
- Coverage   84.18%   68.25%   -15.94%     
===========================================
  Files          47       36       -11     
  Lines        6657     5304     -1353     
===========================================
- Hits         5604     3620     -1984     
- Misses       1053     1684      +631     
Impacted Files Coverage Δ
ogusa/firm.py 88.88% <80.70%> (-11.12%) :arrow_down:
ogusa/parameters.py 77.81% <100.00%> (-6.94%) :arrow_down:
ogusa/tests/test_firm.py 100.00% <100.00%> (ø)
ogusa/get_micro_data.py 33.33% <0.00%> (-64.89%) :arrow_down:
ogusa/income.py 50.00% <0.00%> (-50.00%) :arrow_down:
ogusa/elliptical_u_est.py 60.46% <0.00%> (-39.54%) :arrow_down:
ogusa/utils.py 69.62% <0.00%> (-30.38%) :arrow_down:
ogusa/demographics.py 54.42% <0.00%> (-28.66%) :arrow_down:
ogusa/tests/test_TPI.py 38.88% <0.00%> (-20.93%) :arrow_down:
ogusa/household.py 86.82% <0.00%> (-13.18%) :arrow_down:
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bd9b897...e9f8f8d. Read the comment docs.

codecov-io avatar Jul 26 '19 19:07 codecov-io

@jdebacker . I don't understand the Travis CI error messages for why this is not passing.

rickecon avatar Feb 23 '20 22:02 rickecon

@rickecon This branch isn't up to date with the master. It's still a work in progress. I'll sync and then be moving forward with dynamic firms soon. I've got the theory down, but still testing some functions dealing with different business tax systems on the simpler code over in the OG textbook repo.

jdebacker avatar Feb 24 '20 03:02 jdebacker

Codecov Report

Merging #457 into master will decrease coverage by 0.00%. The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
- Coverage   84.32%   84.32%   -0.01%     
==========================================
  Files          47       47              
  Lines        6973     6941      -32     
==========================================
- Hits         5880     5853      -27     
+ Misses       1093     1088       -5     
Impacted Files Coverage Δ
ogusa/firm.py 79.47% <70.00%> (-20.53%) :arrow_down:
ogusa/parameters.py 84.81% <100.00%> (+0.06%) :arrow_up:
ogusa/tests/test_firm.py 100.00% <100.00%> (ø)
regression/test_regression.py 39.34% <0.00%> (-7.04%) :arrow_down:
ogusa/tests/test_execute.py 68.18% <0.00%> (-6.82%) :arrow_down:
ogusa/tests/test_user_inputs.py 60.71% <0.00%> (-4.92%) :arrow_down:
ogusa/tests/test_basic.py 33.33% <0.00%> (-4.85%) :arrow_down:
ogusa/tests/test_startyears.py 50.00% <0.00%> (-4.17%) :arrow_down:
ogusa/tests/test_run_ogusa.py 32.65% <0.00%> (-3.35%) :arrow_down:
ogusa/tests/test_txfunc.py 65.60% <0.00%> (-2.87%) :arrow_down:
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 69a5e80...a706d41. Read the comment docs.

codecov-commenter avatar Jun 17 '20 21:06 codecov-commenter

Codecov Report

Merging #457 (ac4202a) into master (7816335) will increase coverage by 1.51%. The diff coverage is 84.21%.

:exclamation: Current head ac4202a differs from pull request most recent head 0386723. Consider uploading reports for the commit 0386723 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
+ Coverage   82.81%   84.32%   +1.51%     
==========================================
  Files          23       47      +24     
  Lines        3927     6941    +3014     
==========================================
+ Hits         3252     5853    +2601     
- Misses        675     1088     +413     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ogusa/firm.py 79.47% <70.00%> (-20.53%) :arrow_down:
ogusa/parameters.py 84.81% <100.00%> (+0.06%) :arrow_up:
ogusa/tests/test_firm.py 100.00% <100.00%> (ø)
ogusa/txfunc.py 26.87% <0.00%> (-15.48%) :arrow_down:
ogusa/parameter_plots.py 67.05% <0.00%> (-13.99%) :arrow_down:
ogusa/output_tables.py 88.94% <0.00%> (-7.80%) :arrow_down:
regression/test_regression.py 39.34% <0.00%> (-7.04%) :arrow_down:
ogusa/aggregates.py 96.09% <0.00%> (-3.91%) :arrow_down:
ogusa/tax.py 98.40% <0.00%> (-0.96%) :arrow_down:
ogusa/demographics.py 83.07% <0.00%> (-0.52%) :arrow_down:
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7816335...0386723. Read the comment docs.

codecov-io avatar Oct 16 '20 15:10 codecov-io

Codecov Report

Merging #457 (ac4202a) into master (5cdaad3) will increase coverage by 0.42%. The diff coverage is 84.21%.

:exclamation: Current head ac4202a differs from pull request most recent head 9c8dfe5. Consider uploading reports for the commit 9c8dfe5 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
+ Coverage   83.90%   84.32%   +0.42%     
==========================================
  Files          20       47      +27     
  Lines        3448     6941    +3493     
==========================================
+ Hits         2893     5853    +2960     
- Misses        555     1088     +533     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ogusa/firm.py 79.47% <70.00%> (-20.53%) :arrow_down:
ogusa/parameters.py 84.81% <100.00%> (-2.98%) :arrow_down:
ogusa/tests/test_firm.py 100.00% <100.00%> (ø)
ogusa/TPI.py 76.34% <0.00%> (-16.00%) :arrow_down:
ogusa/txfunc.py 26.87% <0.00%> (-15.33%) :arrow_down:
ogusa/parameter_plots.py 67.05% <0.00%> (-13.99%) :arrow_down:
ogusa/output_tables.py 88.94% <0.00%> (-7.80%) :arrow_down:
regression/test_regression.py 39.34% <0.00%> (-7.04%) :arrow_down:
ogusa/aggregates.py 96.09% <0.00%> (-3.91%) :arrow_down:
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5cdaad3...9c8dfe5. Read the comment docs.

codecov-commenter avatar Jul 20 '21 18:07 codecov-commenter