John Cormie

Results 25 comments of John Cormie

Can you update this to the latest piper revision ? Also please move the PeerUidTestHelper from src/main/ to src/testFixtures/. PeerUidTestHelperTest should stay in src/test/

Can you make sure the whitespace and formatting complies with https://github.com/grpc/grpc-java/blob/master/CONTRIBUTING.md#code-style ?

The loss of ManagedChannelBuilder#nameResolverFactory would be problematic for PackageManager-based service discovery on Android. Such an NRP needs an instance of PackageManager to do its job, but this object isn't globally...

> Well, sure. But if you are going to need some custom resolver that is just for your library, then use a more unique scheme: my-lib-resolver:. Thanks for the answer!...

Thanks for addressing this! I'm curious though: what's wrong with specifying the registry with a ManagedChannelBuilder method? I'm surprised to hear that you consider this "changing the name resolver in...

> Thanks! > > 1. I think we should move these platform declaration to subfolder if we want to remove `android_` prefix, maybe `bazel/platforms/android/BUILD`. (In google's internal repo we declare...

This is affecting us in grpc as well. We upgraded to Bazel 7 & Android Platforms in https://github.com/grpc/grpc/pull/36116 and named our platforms `android_$ARCH` as suggested by [the blog's official announcement](https://blog.bazel.build/2023/11/15/android-platforms.html)...

Thanks for confirming katre! Since these lib/ directory names are a fixed part of android and the same for everyone, what would you think of an alternative where the native...

> We're trying to remove most usages of Attributes. In general, we are replacing them with the same pattern of having a reference-equality Key with a generic for typing. Can...