John Cormie
John Cormie
@markb74 Any ideas on how to handle this?
Can you update this to the latest piper revision ? Also please move the PeerUidTestHelper from src/main/ to src/testFixtures/. PeerUidTestHelperTest should stay in src/test/
Can you make sure the whitespace and formatting complies with https://github.com/grpc/grpc-java/blob/master/CONTRIBUTING.md#code-style ?
The loss of ManagedChannelBuilder#nameResolverFactory would be problematic for PackageManager-based service discovery on Android. Such an NRP needs an instance of PackageManager to do its job, but this object isn't globally...
> Well, sure. But if you are going to need some custom resolver that is just for your library, then use a more unique scheme: my-lib-resolver:. Thanks for the answer!...
Thanks for addressing this! I'm curious though: what's wrong with specifying the registry with a ManagedChannelBuilder method? I'm surprised to hear that you consider this "changing the name resolver in...