grpc-java icon indicating copy to clipboard operation
grpc-java copied to clipboard

Helper class to allow in process servers to use peer uids in test

Open abtom opened this issue 1 year ago • 5 comments

We use in process servers for testing which currently does not allow the use peer uids due to InProcessBuilder not setting the correct values. Adding a test only interceptor so that we can use peer uids in in process servers.

abtom avatar Mar 14 '24 03:03 abtom

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: abtom (888f97ff75687f054f635520079ca208b7408fef, fbb606003b5191d4479f72665311ef13e8dc0261, b0bd2a07f6663c365eda8ea6e13ec25091556758, b0420b8883b664de6abbb937e495770e23108351, 119a969696e7b6687c1c9d47c73af3faae3a0fce, 099283dd3ab61e2e109ca594d21e639fc266cc40, 4fc0f2626bacdbc81b47ae0f5052c837f8d61944, 2788ba5dda063b455e5c7e008cb24ad1738783bd)

See cl/613744041

abtom avatar Mar 14 '24 12:03 abtom

Can you update this to the latest piper revision ?

Also please move the PeerUidTestHelper from src/main/ to src/testFixtures/. PeerUidTestHelperTest should stay in src/test/

jdcormie avatar Mar 18 '24 18:03 jdcormie

updated

abtom avatar Mar 20 '24 01:03 abtom

Can you make sure the whitespace and formatting complies with https://github.com/grpc/grpc-java/blob/master/CONTRIBUTING.md#code-style ?

jdcormie avatar Mar 20 '24 04:03 jdcormie