Julien Danjou

Results 247 comments of Julien Danjou

Mergify always asks and trust behind about the mergeable state of a PR. If branch protections are in place, then the PR is reported as being `blocked` and Mergify won't...

@edahlseng I think that's what @sileht's doing in #324

That might be more than that. You can easily get other warnings such as: ``` error: Argument 1 to "len" has incompatible type "MyClass"; expected "Sized" error: Value of type...

I don't know why it does this, but I found a workaround for gunicorn which is: ``` diff --git gunicorn/arbiter.py gunicorn/arbiter.py index 0e705075..aacf883d 100644 --- gunicorn/arbiter.py +++ gunicorn/arbiter.py @@ -612,6...

We could probably add a little helper module for common use cases like that.

The `level` argument is global. What you want do is: ``` def create_logger(log_path, log_name, log_level=logging.INFO): daiquiri.setup( outputs=(daiquiri.output.File( directory=log_path, program_name=log_name), daiquiri.output.STDOUT,)) logger = daiquiri.getLogger(program_name=log_name) logger.setLevel(log_level) return logger ```

Setting documentation tag since it could be a cool example in doc.

@shlomiLan My bad, the adapter returned by daiquiri does not support that. We should probably enhance that too. Try: ```python def create_logger(log_path, log_name, log_level=logging.INFO): daiquiri.setup( outputs=(daiquiri.output.File( directory=log_path, program_name=log_name), daiquiri.output.STDOUT,)) logging.getLogger(log_name).setLevel(log_level)...

I never tried. Do you have some links or code sample you can share that can help understanding the issue and how to solve it?

Oh we should definitely switch to colorama. @blakev maybe you should take a look into that for https://github.com/jd/daiquiri/pull/9 ?