Julien Danjou

Results 224 comments of Julien Danjou

It seems that it tries to load something over the Internet and is failing: ``` /Users/charles/Sites/books/tools/asciidoc-book-toolchain/book.xml:2: warning: failed to load external entity "http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd" ``` I guess it should use a...

Each `tenacity.Retrying` has a `statistics` attribute that you can use to access the number of retries. I'll let this bug open to make sure its documened somewhere.

@mhindery I don't think you need a closure. You can just reference the function directly: ```python >>> import tenacity >>> @tenacity.retry ... def x(): ... print(x.retry.statistics) ... >>> x() {'start_time':...

You should define it as a classmethod or a method, not a staticmethod. It calls itself inside a class, so it's not static.

@naphta that's not needed, see the discussion.

The only solution that I see is to iterate before ever trying the first call. That sounds like something dangerous. Best thing is probably to document that the caller is...

It'd probably better to have a flag because iterators can have different and side effect behaviour, so it might do weird stuff otherwise.

LGTM but circleci is broken again :(

Not sure why tests fail?

Doc is meant to be read once rendered properly by Sphinx on http://tenacity.readthedocs.io/ I guess we cut down the README rendered on PyPI to just a link.