terraform-provider-github
terraform-provider-github copied to clipboard
Add "web" and "api" IP blocks published by GitHub
For some reason the "web" and "api" blocks published at https://api.github.com/meta are missing from the github_ip_ranges data source, this intends to remedy that. I'm not sure why they aren't included in the first place.
Also... I don't code in GoLang and lack the tooling as well as the ability to test this locally, but it seemed easy enough to add the bits of code needed for this PR. Which is to say, I hope this looks OK and I didn't miss anything.
@fabiendelpierre thanks for getting this published for review. This one makes sense for an upcoming feature release. It is now tracked for further testing.
🤔 our underlying library does not have support for this and the GraphQL API is also not showing support for the web
and api
blocks.
My recommendation is we wait on better support for this data and will ask internally to get clarity on when we can expect these fields to be visible in the GraphQL API.
It would be great if the "actions" IP ranges could be incorporated into this PR when the underlying hurdles are removed. Like the others it should be similarly simple if the library support is there.
See #351
Closing in favor of #1220.